Address dlite-validate output confusing information #988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If I understood issue #978 correctly, we should not show the warning about the behavior change from
dlite-validate
. I agree on that.But how is this solved best? The current implementation expects the user to set environment variable
DLITE_BEHAVIOR=OFF
to turn off all warnings about behavior changes. If we are happy with that, we are done.If we want tools like
dlite-validate
to never show warnings about behavior changes, we need more. Possible approaches:DLITE_BEHAVIOR=OFF
within the tool before importingdlite
. This is currently implemented in this PR. It is quite a hack and not a very attractive solution...dlite
is imported from Python, it could look for global variables starting with "DLITE_" and set corresponding environment variables internally. I like this better, since it would be a quite general and nice way to configuredlite
from Python applications. Now implemented in PR Initialise environment from global Python variables #989Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.