Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address dlite-validate output confusing information #988

Closed

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Oct 27, 2024

Description

If I understood issue #978 correctly, we should not show the warning about the behavior change from dlite-validate. I agree on that.

But how is this solved best? The current implementation expects the user to set environment variable DLITE_BEHAVIOR=OFF to turn off all warnings about behavior changes. If we are happy with that, we are done.

If we want tools like dlite-validate to never show warnings about behavior changes, we need more. Possible approaches:

  • Set DLITE_BEHAVIOR=OFF within the tool before importing dlite. This is currently implemented in this PR. It is quite a hack and not a very attractive solution...
  • If dlite is imported from Python, it could look for global variables starting with "DLITE_" and set corresponding environment variables internally. I like this better, since it would be a quite general and nice way to configure dlite from Python applications. Now implemented in PR Initialise environment from global Python variables #989

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Oct 27, 2024 that may be closed by this pull request
@jesper-friis jesper-friis added wontfix This will not be worked on and removed wontfix This will not be worked on labels Oct 27, 2024
@jesper-friis
Copy link
Collaborator Author

Closing this PR, since a better solution was implemented in PR #989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dlite-validate output confusing information
1 participant