implement experimental "pure" numpy sbe hex read #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses some of the nice new "strings" functionality in numpy 2 to speed things up in the read_hex function.
In one of the largest hex files I could find in the r2r breakout examples, this change speeds up the reading of hex by about 2.2x (333ms vs 749ms), the slowest part is actually writing the file to disk.
I'm not sure if the strangeness of the "pure" numpy code is worth it though, really you'd only need to read the files once and just use the netCDF after.
Didn't write tests, but the existing ones pass. This PR doesn't need to be merged ever if we don't want it.