Add fax/t38 support #129
Merged
Add fax/t38 support #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // TODO: we don't do anything with image_port right now.. |
There was a problem hiding this comment.
Worth a note to say what we should do with it in future (and what the impact of not doing anything is)?
|
One comment, but otherwise looks good - merge at will. |
Taken from https://code.osso.nl/projects/sipp/changeset/c939d058337f/ and adapted. (Still root-only pcap_play.)
uhle
added a commit
to uhle/sipp
that referenced
this pull request
Feb 8, 2021
wdoekes
pushed a commit
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #42 .
This is implemented without the no-root pcap_play requested in #57; that will have to wait for another day.
It was tested by creating fax test setup with the sipp-osso client and then moving to this branch.