FIXME: 코드 1차 수정 #77
Closed
FIXME: 코드 1차 수정 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooyoung2309
reviewed
Dec 7, 2023
Comment on lines
+14
to
+25
| struct SolvedQuizClient { | ||
| var fetch: (Int) async -> Result<[SolvedQuizEntity], D3NAPIError> | ||
| } | ||
|
|
||
| extension SolvedQuizClient: TestDependencyKey { | ||
| static let previewValue = Self( | ||
| fetch: { _ in .failure(.none) } | ||
| ) | ||
|
|
||
| static let testValue = Self( | ||
| fetch: unimplemented("\(Self.self).fetch") | ||
| ) |
There was a problem hiding this comment.
client를 또 추가할 필요가 없는 이유는 Quiz라는 도메인으로 묶어서 생각할 수 있기 때문이라고 생각합니다. 기존에 있는 QuizClient에 fetchSolved를 하는 방식이 응집도가 높아서 더 좋아보입니다.
Comment on lines
+13
to
+31
| public enum SolvedQuizService { | ||
| case fetch | ||
| } | ||
|
|
||
| extension SolvedQuizService: TargetType { | ||
| public var baseURL: URL { URL(string: Environment.baseURL)! } | ||
|
|
||
| public var path: String { | ||
| switch self { | ||
| case .fetch: return "quiz/list/solved" | ||
| } | ||
| } | ||
|
|
||
| public var method: Moya.Method { | ||
| switch self { | ||
| case .fetch: return .get | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
비슷한 피드백으로 QuizService에 들어가야할 내용이라고 생각합니다. 그리고 이미 들어가있는것으로 알고있습니다!
|
흠... 다시 생각해보니 많은 부분들이 이미 존재하는 quizclient와 quizservice에서 가져올 수 있는 부분들이네요. branch를 다시 만들어서 처음부터 다시 고민해보겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 요약
📌 변경 사항
✅ PR check list
Linked Issue
close #76