1.13+ update

[barpec12]

This PR gives you possibility to run 1.13 and further versions on SKCraft. Enjoy! :)

[workingovertime]

This really needs to be committed soon!!

[Routhinator]

Does this fix the builder? And does this move all versions of MC downloading to the new location? I've noticed that these pulls all target 1.13+ only, but MS is moving ALL downloads to the new location, not just 1.13+. And the old location is due to be removed/deprecated by the end of this month.

[barpec12]

@Routhinator These pulls support all versions. Builder works as well.

[jkroepke]

Builder works fine (test w/ vanilla 1.13.2)

[info] 
[info] --- Reading version manifest... ---
[info] Fetching version manifest from https://launchermeta.mojang.com/v1/packages/df66b5a5f451d026c356ead8caf118c71919850b/1.13.2.json...
[info] 
[info] --- Scanning for .info.json files... ---

[jkroepke]

@barpec12 But i'm unable to run an 1.13.2 instance on MacOS

[information] Building asset virtual tree at '/Users/jan/IdeaProjects/atu-launcher/./assets/virtual/1.13.1'...
[information] Process ended; cleaning up /Users/jan/IdeaProjects/atu-launcher/./temp/extract/1545613825225
[warnung] Task failed
java.lang.NullPointerException
	at com.skcraft.launcher.launch.Runner.addJarArgs(Runner.java:280)
	at com.skcraft.launcher.launch.Runner.call(Runner.java:137)
	at com.skcraft.launcher.launch.Runner.call(Runner.java:45)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Any idea?

Edit:

Using
https://github.com/SKCraft/Launcher/pull/270/files#diff-b32c7d66902b469aa875f05f00bed9efR281
instead the line above results into a successful launch.

[barpec12]

Good idea, I will correct that in a few days.

[jkroepke]

Found an other issue. If I compare the versionManifest between https://launchermeta.mojang.com/v1/packages/df66b5a5f451d026c356ead8caf118c71919850b/1.13.2.json and my own I see that versionManifest.arguments.jvm is completely missing. Its mandatory for OSX again since MC need the JVM flag -XstartOnFirstThread which is only available at OSX.

[jkroepke]

@barpec12 if its okay I would extend this PR with the features around the arguments?

[barpec12]

if its okay I would extend this PR with the features around the arguments?

That would be nice.

[jkroepke]

That would be nice.

After some research I think I need a custom deserializer to map the arguments into Java objects becuase the type of the arguments game and arguments jvm isn't constant.

I can not provide it because my java skill are just limited to stack overflow ...

But i think its important for future compability of minecraft. (For now we need -XstartOnFirstThread on OSX otherwise Minecraft will not start anymore)

[LoneDev6]

When will this committed? I need to install Fabric 1.14.4 as loader, thanks

[spannerman79]

@LoneDev6 you'll need to add this to your own fork until @sk89q updates

[LoneDev6]

Added it thanks
I hope anyone will solve the fabric issue

[SDUBZ]

How do i PR this into my own build since i didnt directly fork but made from source then made on gh later on after i edited things 🤔

[barpec12]

@SDUBZ I don't see anything like this. Can you send me a github link to this line?

[barpec12]

That's not a bug. You are trying to merge my changes into your repository. Unfortunately there are some conflicts you have to solve manually. Read https://stackoverflow.com/questions/10657315/git-merge-left-head-marks-in-my-files

[spannerman79]

@SDUBZ PR's are to review and comment on code that may or may not have issues when it comes to the base repo, to raise points specific to the PR to which the PR is being requested to be included within.

A PR is not a tech support place. https://help.github.com/en/articles/about-pull-requests

[hedgehog1029]

Superseded by the changes in master; thanks anyway!