Version/1.21.11 dev #6

TheBjoRedCraft · 2026-01-12T18:59:19Z

No description provided.

… handling, and update dependencies

…jects

… update project version to 1.21.11-1.0.2-SNAPSHOT

…ne player count

…f` for `entries`, clean up unused utilities, and optimize tablist management logic

…pdateForOthers`, adjust usages across services, and clean up tablist handling logic

…nsure base server is included in the result

…List`, ensure base server is included in the result" This reverts commit 1a92bf8.

…` and `updateForOthers`, adjust usages across services, and clean up tablist handling logic" This reverts commit f808c82.

…add `toMutableObjectList` for distinct server handling

…nces with UUID handling, and enhance Redis event processing

…service and listener logic, and improve Redis event handling

…e profile conversions

…lan integration with Redis event publishing, and enhance tablist management logic with better serialization

…nt debug prints, and streamline event processing logic

…yApi` for Redis integration, streamline `RedisApi` creation, and improve API dependency definitions

Copilot

Pull request overview

This PR represents a significant refactoring of the tab list plugin for version 1.21.11, transitioning from a centralized server-side tab entry management system to a more distributed, event-driven architecture. The changes simplify the codebase by removing complex server grouping logic and unused utilities.

Changes:

Refactored tab list service to use direct Velocity tab list manipulation instead of maintaining a separate entry collection
Introduced new Redis events for tab visibility control (hide/show) and entry updates
Added optional integration with surf-clan-velocity plugin for clan tag display
Updated build configuration to use surf-redis and improved publishing workflow

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
gradle.properties	Version bump from 1.0.0 to 1.0.2-SNAPSHOT
build.gradle.kts	Updated gradle plugin version with dynamic selector and added publishing configuration
surf-tab-api/build.gradle.kts	Changed from velocity to core API and added surf-redis dependency
surf-tab-velocity/build.gradle.kts	Integrated surf-redis via API configuration and added optional clan plugin dependency
player-util.kt	Removed entire file containing Velocity-specific conversion utilities
formatting-util.kt	Simplified formatWithAdventure function, removed dynamic resolver and relational audience support
clan-member-util.kt	Added new utility to check if clan members are online
TablistService.kt	Complete rewrite replacing centralized entry management with direct tab list formatting
TabEntryRemoveRedisEvent.kt	Simplified to only contain UUID, removed server parameter
TabEntryAddRedisEvent.kt	Simplified to only contain UUID, removed tab entry and server parameters
TabRedisEventListener.kt	Added hide/show/update event handlers and refactored add/remove logic
ConnectionListener.kt	Simplified connection handling, removed server change tracking
LuckPermsHook.kt	Added async prefix/suffix retrieval and changed to publish update events via Redis
TablistConfig.kt	Removed nameFormat and groups configuration
SurfTabCommand.kt	Removed manual tab list update on reload
VelocityMain.kt	Added clan modification listener integration
TabShowRedisEvent.kt	New event for showing hidden tab entries
TabHideRedisEvent.kt	New event for hiding tab entries
TabEntryUpdateRedisEvent.kt	New event for updating existing tab entries
publish.yml	New GitHub Actions workflow for automated publishing
gradlew	Added Gradle wrapper script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T19:03:22Z

surf-tab-velocity/src/main/kotlin/dev/slne/surf/tab/velocity/service/TablistService.kt

+    private fun getClanTag(playerUuid: UUID) =
+        if (plugin.proxy.pluginManager.isLoaded("surf-clan-velocity")) MiniMessage.miniMessage()
+            .serialize(
+                surfClanApi.renderClanTag(
+                    playerUuid
+                )
+            ) else ""


The getClanTag function checks if the surf-clan-velocity plugin is loaded, but if an error occurs while calling surfClanApi.renderClanTag (e.g., the API is not initialized), it could throw an exception. Consider adding error handling to return an empty string if the API call fails, ensuring robustness when the optional dependency is loaded but not properly initialized.

Suggested change

private fun getClanTag(playerUuid: UUID) =

if (plugin.proxy.pluginManager.isLoaded("surf-clan-velocity")) MiniMessage.miniMessage()

.serialize(

surfClanApi.renderClanTag(

playerUuid

)

) else ""

private fun getClanTag(playerUuid: UUID): String {

if (!plugin.proxy.pluginManager.isLoaded("surf-clan-velocity")) {

return ""

}

return try {

MiniMessage.miniMessage()

.serialize(

surfClanApi.renderClanTag(

playerUuid

)

)

} catch (e: Exception) {

""

}

}

Copilot · 2026-01-12T19:03:23Z

surf-tab-velocity/src/main/kotlin/dev/slne/surf/tab/velocity/listener/ConnectionListener.kt

    @Subscribe
    fun onKick(event: KickedFromServerEvent) {
        val player = event.player
-        val server = event.server
-
-        redisApi.publishEvent(
-            TabEntryRemoveRedisEvent(
-                player.uniqueId, server
-            )
-        )
    }


The onKick function now has an empty body. Similar to onDisconnect, if this handler is no longer needed, it should be removed entirely. Empty event handlers that remain registered can cause confusion and add unnecessary overhead.

Copilot · 2026-01-12T19:03:23Z

surf-tab-velocity/src/main/kotlin/dev/slne/surf/tab/velocity/redis/TabRedisEventListener.kt

+        hiddenEntries[event.player] = (hiddenEntries[event.player] ?: mutableListOf()) + entry

-        tablistService.entries.add(event.tabEntry)
+        player.tabList.removeEntry(event.toHide)
+    }

-        visiblePlayers.forEach {
-            tablistService.addPlayer(it, event.tabEntry)
-        }
+    @OnRedisEvent
+    fun onTabShow(event: TabShowRedisEvent) {
+        val player = plugin.proxy.getPlayer(event.player).getOrNull() ?: return
+        val entry = hiddenEntries[event.player]?.find { it.profile.id == event.toShow } ?: return
+
+        hiddenEntries[event.player] =
+            hiddenEntries[event.player]?.filterNot { it.profile.id == event.toShow }
+                ?: mutableListOf()


The hiddenEntries map uses a mutable list pattern but creates a new list on each update. Consider using a mutableListOf() or mutableSetOf() to avoid unnecessary list recreation. The current pattern at lines 24 and 34-36 creates new lists on every modification which is inefficient.

Copilot · 2026-01-12T19:03:23Z

.github/workflows/publish.yml

+  SLNE_SNAPSHOTS_REPO_PASSWORD: ${{ secrets.SLNE_SNAPSHOTS_REPO_PASSWORD }}
+  SLNE_RELEASES_REPO_USERNAME: ${{ secrets.SLNE_RELEASES_REPO_USERNAME }}
+  SLNE_RELEASES_REPO_PASSWORD: ${{ secrets.SLNE_RELEASES_REPO_PASSWORD }}
+  MODULE_REGEX: "surf-tab-api.*-all\\.jar$|surf-tab-velocity.*-all\\.jar$"


The variable name MODULE_REGEX suggests it should be a regex pattern, but it's actually used with grep -E which expects an extended regex pattern. The current value uses shell filename patterns (ending with $) which is correct, but the name could be more descriptive such as MODULE_JAR_PATTERN to clarify its purpose.

Copilot · 2026-01-12T19:03:23Z

surf-tab-velocity/src/main/kotlin/dev/slne/surf/tab/velocity/redis/TabRedisEventListener.kt

+    fun onTabShow(event: TabShowRedisEvent) {
+        val player = plugin.proxy.getPlayer(event.player).getOrNull() ?: return
+        val entry = hiddenEntries[event.player]?.find { it.profile.id == event.toShow } ?: return
+
+        hiddenEntries[event.player] =
+            hiddenEntries[event.player]?.filterNot { it.profile.id == event.toShow }
+                ?: mutableListOf()
+
+        player.tabList.addEntry(entry)
    }


In the onTabShow function, if the entry is not found in hiddenEntries, the function returns early without providing any feedback. However, the subsequent code at lines 34-36 will still execute even when entry is null due to the null-safe find operation. The logic should ensure that hiddenEntries cleanup only happens when an entry is actually found and restored.

Copilot · 2026-01-12T19:03:24Z

surf-tab-velocity/src/main/kotlin/dev/slne/surf/tab/velocity/listener/ConnectionListener.kt

    fun onDisconnect(event: DisconnectEvent) {
        val player = event.player
-        val server = player.currentServer.getOrNull()?.server ?: return

-        redisApi.publishEvent(
-            TabEntryRemoveRedisEvent(
-                player.uniqueId, server
-            )
-        )
+
    }


The onDisconnect function now has an empty body. If this is intentional and the disconnect logic has been removed, this handler should either be removed entirely or a comment should be added explaining why it's intentionally empty. Empty event handlers can be confusing for maintainability.

Copilot · 2026-01-12T19:03:24Z

surf-tab-velocity/src/main/kotlin/dev/slne/surf/tab/velocity/hook/LuckPermsHook.kt

+        return luckPerms.userManager.getUser(player) ?: luckPerms.userManager.loadUser(player)
+            .await()


The getOrLoadUser function can return null from getUser and fall back to loadUser, but there's no null check after the await() call. If loadUser().await() also returns null, this will cause a NullPointerException. Consider adding a null safety check or documenting that loadUser is guaranteed to return a non-null User.

Suggested change

return luckPerms.userManager.getUser(player) ?: luckPerms.userManager.loadUser(player)

.await()

val existingUser = luckPerms.userManager.getUser(player)

if (existingUser != null) {

return existingUser

}

val loadedUser = luckPerms.userManager.loadUser(player).await()

return requireNotNull(loadedUser) {

"LuckPerms returned null when loading user data for '$player'"

}

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

TheBjoRedCraft added 17 commits December 24, 2025 14:15

feat: add GitHub Actions workflow for publishing, enhance Redis event…

28eae48

… handling, and update dependencies

chore: chmod

600fa08

chore: configure slneReleases repository for publishing in all subpro…

8df9116

…jects

feat: extend TabShowRedisEvent and TabHideRedisEvent from RedisEvent,…

23553d8

… update project version to 1.21.11-1.0.2-SNAPSHOT

fix: use playerCount instead of allPlayers.size to determine onli…

f4ad73c

…ne player count

refactor: replace mutableObjectSetOf with `mutableObject2ObjectMapO…

a36b951

…f` for `entries`, clean up unused utilities, and optimize tablist management logic

refactor: split updatePlayerInTablist into updateOthersFor and `u…

f808c82

…pdateForOthers`, adjust usages across services, and clean up tablist handling logic

refactor: simplify getSeenServers by using toMutableObjectList, e…

1a92bf8

…nsure base server is included in the result

Revert "refactor: simplify getSeenServers by using `toMutableObject…

b6858f4

…List`, ensure base server is included in the result" This reverts commit 1a92bf8.

Revert "refactor: split updatePlayerInTablist into `updateOthersFor…

4be0ab8

…` and `updateForOthers`, adjust usages across services, and clean up tablist handling logic" This reverts commit f808c82.

refactor: enhance getSeenServers by adding base server explicitly, …

22eb17a

…add `toMutableObjectList` for distinct server handling

refactor: streamline tablist management, replace direct server refere…

62f6d58

…nces with UUID handling, and enhance Redis event processing

refactor: remove unused TabEntryRemoveRedisEvent, clean up tablist …

cd9dd27

…service and listener logic, and improve Redis event handling

refactor: remove unused player-util functions for tab profile and gam…

995158c

…e profile conversions

refactor: migrate TabEntryUpdateRedisEvent to API module, improve c…

7239913

…lan integration with Redis event publishing, and enhance tablist management logic with better serialization

refactor: clean up logging in TabRedisEventListener, remove redunda…

f0f585f

…nt debug prints, and streamline event processing logic

refactor: update Gradle scripts to use surfCoreApi and `surfVelocit…

250d7fa

…yApi` for Redis integration, streamline `RedisApi` creation, and improve API dependency definitions

Copilot AI review requested due to automatic review settings January 12, 2026 18:59

Copilot started reviewing on behalf of TheBjoRedCraft January 12, 2026 18:59 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

JoField08 approved these changes Jan 12, 2026

View reviewed changes

JoField08 enabled auto-merge January 12, 2026 23:24

Copilot AI reviewed Jan 14, 2026

View reviewed changes

ammodev approved these changes Jan 17, 2026

View reviewed changes

JoField08 added this pull request to the merge queue Jan 17, 2026

Merged via the queue into version/1.21.11 with commit 01b9fc3 Jan 17, 2026
7 checks passed

TheBjoRedCraft deleted the version/1.21.11-dev branch January 22, 2026 18:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version/1.21.11 dev #6

Version/1.21.11 dev #6

Uh oh!

TheBjoRedCraft commented Jan 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		return luckPerms.userManager.getUser(player) ?: luckPerms.userManager.loadUser(player)
		.await()

-        return luckPerms.userManager.getUser(player) ?: luckPerms.userManager.loadUser(player)
-            .await()
+        val existingUser = luckPerms.userManager.getUser(player)
+        if (existingUser != null) {
+            return existingUser
+        }
+        val loadedUser = luckPerms.userManager.loadUser(player).await()
+        return requireNotNull(loadedUser) {
+            "LuckPerms returned null when loading user data for '$player'"
+        }

Version/1.21.11 dev #6

Version/1.21.11 dev #6

Uh oh!

Conversation

TheBjoRedCraft commented Jan 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants