Skip to content

Commit

Permalink
remove commented code
Browse files Browse the repository at this point in the history
  • Loading branch information
avpalienko committed Apr 16, 2024
1 parent 0c77f2e commit 838318c
Showing 1 changed file with 0 additions and 34 deletions.
34 changes: 0 additions & 34 deletions src/backends/oracle/blob.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -161,40 +161,6 @@ void oracle_blob_backend::set_lob_locator(oracle_blob_backend::locator_t locator
}

initialized_ = initialized;
/*
* see https://docs.oracle.com/cd/A91202_01/901_doc/appdev.901/a89857/oci07lob.htm#436746
* The explicitly open/closing LOB technique is dangerous, as it can lead to errors.
* The LOB opening and closing mechanism has the following restrictions:
An application must close all previously opened LOBs before committing a transaction. Failing to do so will result in an error.
If a transaction is rolled back, all open LOBs are discarded along with the changes made (the LOBs are not closed), so associated triggers are not fired.
It is an error to open or close the same internal LOB twice within the same transaction, either with different locators or the same locator.
It is an error to close a LOB that has not been opened.
* TODO: This method should be used explicitly by the user
*
if (initialized)
{
boolean already_open = FALSE;
sword res = OCILobIsOpen(session_.svchp_, session_.errhp_, lobp_, &already_open);
if (res != OCI_SUCCESS)
{
throw_oracle_soci_error(res, session_.errhp_);
}
if (!already_open)
{
res = OCILobOpen(session_.svchp_, session_.errhp_, lobp_, OCI_LOB_READWRITE);
if (res != OCI_SUCCESS)
{
throw_oracle_soci_error(res, session_.errhp_);
}
}
}
*/
}

void oracle_blob_backend::reset()
Expand Down

0 comments on commit 838318c

Please sign in to comment.