Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the datetime (with up to nanoseconds) has been added #1089

Closed
wants to merge 8 commits into from

Conversation

avpalienko
Copy link

No description provided.

@vadz
Copy link
Member

vadz commented Oct 12, 2023

The build failures must be fixed, of course, but beyond this could I ask you to please avoid mixing up whitespace-only changes and variable renaming with the significant changes? If you really want to, you can make them in separate commits (or maybe separate PRs later), but having them all here makes it much harder to review the changes than necessary, so could you please undo all the cosmetic changes? TIA!

@avpalienko
Copy link
Author

The build failures must be fixed, of course, but beyond this could I ask you to please avoid mixing up whitespace-only changes and variable renaming with the significant changes? If you really want to, you can make them in separate commits (or maybe separate PRs later), but having them all here makes it much harder to review the changes than necessary, so could you please undo all the cosmetic changes? TIA!

Sorry, this was not on purpose - these are IDE settings on my project. I've undone it

@vadz
Copy link
Member

vadz commented Oct 14, 2023

Thanks for the updates, but there still seems to be a big number of unrelated changes (e.g. all MSVC-specific stuff) as well as many changes to the tests which I wouldn't expect (I'd only expect additions, not changes to the existing tests) and the PR is just huge -- it's going to be very hard to find time to review it, so any further efforts to reduce its size would be welcome.

One global question is why exactly do we need the third-party date header? Can't we live with just the functionality that standard chrono provides?

@avpalienko
Copy link
Author

Thanks for the updates, but there still seems to be a big number of unrelated changes (e.g. all MSVC-specific stuff) as well as many changes to the tests which I wouldn't expect (I'd only expect additions, not changes to the existing tests) and the PR is just huge -- it's going to be very hard to find time to review it, so any further efforts to reduce its size would be welcome.

I've created new PR as diff -w. I hope this reduces the number of unrelated changes.

One global question is why exactly do we need the third-party date header? Can't we live with just the functionality that standard chrono provides?

Third party header is https://howardhinnant.github.io/date/date.html. I can't do it myself using chrono. I've read this date.h is a part of of C++20

@avpalienko avpalienko closed this Oct 16, 2023
@avpalienko avpalienko deleted the add-milliseconds branch October 16, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants