Move check for PostgreSQL 9.3 to CMake from the source file #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately pg_config.h is not available in all installations under Windows, so don't rely on being able to include it and instead check POSTGRESQL_VERSION in CMake and define SOCI_POSTGRESQL_NO_LO64 if necessary. This has an additional advantage of allowing to test this code easily even when using PostgreSQL >= 9.3 by turning on this option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately pg_config.h is not available in all installations under
Windows, so don't rely on being able to include it and instead check
POSTGRESQL_VERSION in CMake and define SOCI_POSTGRESQL_NO_LO64 if
necessary.
This has an additional advantage of allowing to test this code easily
even when using PostgreSQL >= 9.3 by turning on this option.