Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix row::move_as behavior breaking reusability #1145

Closed
wants to merge 4 commits into from

Commits on Aug 31, 2024

  1. Sketch fix

    Krzmbrzl committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    57a314c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c3c468 View commit details
    Browse the repository at this point in the history
  3. Adapt test case

    Krzmbrzl committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    6c35d77 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Fix blob fetching semantics in Oracle

    Previously, the into-type would take the blob object's LOB locator
    object and bind that in the query. That works as long as there is only a
    single Blob object being fetched from the database. However, if multiple
    values are fetched consecutively, there would only be a single locator
    object involved. In the best case, this leads to every new fetch
    overriding the previous result and in the worst case, that previous
    result has been turned into an independent blob object that has gone out
    of scope, which leads to freeing of this shared locator.
    
    With this commit, the into-type object will create its own locator
    object and use that. When assigning the fetched result to a blob object,
    the locator is copied such that the into-type and the blob keep
    independent locator objects, i.e. the locator is no longer shared.
    Krzmbrzl committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    f110c69 View commit details
    Browse the repository at this point in the history