Make Que an optional dependency via job source adapters#33
Merged
saturnflyer merged 2 commits intomainfrom Feb 10, 2026
Merged
Conversation
Introduce a Jobs module with the same adapter pattern used by Exceptions and Warnings: a Base class, a registry with factory method, and a Que adapter that extracts the SQL logic from the former QueReporter. JobReporter delegates data-fetching to the configured adapter. Added: Jobs adapter pattern with Base class and registry Added: Jobs::Que adapter for Que job backend Added: JobReporter that delegates to a configurable job source adapter
Wire up JobReporter and Jobs module across the codebase. Remove QueReporter and its hard Que dependency. Job monitoring is now opt-in via config.job_source. Changed: Job monitoring uses configurable adapter pattern via config.job_source Removed: Hard dependency on que gem Removed: QueReporter class (replaced by JobReporter + Jobs adapters) Version: major
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jobsadapter module (mirroring the existingWarningsandExceptionspatterns) with aBaseclass, registry, and aQueadapterJobReporterthat delegates data-fetching to a configured adapterQueReporterand the hardquegem dependencyconfig.job_source = :que(or a custom adapter)Breaking Changes
Newshound::QueReporterhas been removed — useNewshound::JobReporterinsteadquegem is no longer a runtime dependency — apps using Que must add it to their own Gemfileconfig.job_source = :queto their Newshound initializerTest plan
bundle exec rake spec)bundle exec standardrb)config.job_source = :quethat banner shows job statsconfig.job_sourcethat banner renders without job section errors