Add helper methods to ExceptionReporter#34
Merged
saturnflyer merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
Extract formatted_exception_count and exception_summary from the rake task into ExceptionReporter so the logic is testable and reusable. Update the rake task to use the new methods. Added: ExceptionReporter#formatted_exception_count and #exception_summary helpers Fixed: test_exceptions rake task calling report instead of banner_data
saturnflyer
force-pushed
the
reporter-helpers
branch
from
e92f17e to
e440188
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatted_exception_countandexception_summaryfrom the rake task intoExceptionReporterso the logic is testable and reusabletest_exceptionsrake task which was callingreport(returns block-kit sections array) instead ofbanner_data(returns hash with:exceptionskey), causing aTypeErrorTest plan
bundle exec rspec spec/newshound/exception_reporter_spec.rb— 14 examples, 0 failures