[UI/#37] 상세페이지 화면 구현 #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm991014
reviewed
Jan 19, 2025
| textColor: Color, | ||
| textStyle: TextStyle, | ||
| shape: Shape, | ||
| modifier: Modifier = Modifier |
There was a problem hiding this comment.
p1: 콤마 ~ 마지막으로 전체 한 번 확인해주세용
jm991014
reviewed
Jan 19, 2025
Comment on lines
61
to
73
| Row(verticalAlignment = Alignment.CenterVertically) { | ||
| Icon( | ||
| imageVector = icon, | ||
| contentDescription = null, | ||
| tint = Color.Unspecified, | ||
| modifier = Modifier.size(18.dp), | ||
| ) | ||
| Spacer(modifier = Modifier.width(8.dp)) | ||
| Text( | ||
| text = message, | ||
| style = textStyle, | ||
| color = textColor, | ||
| ) |
There was a problem hiding this comment.
CommonSnackbar라면 디자인시스템대로 아이콘이 있는 경우, 없는 경우 고려해서 고쳐주시면 좋을 것 같아요~
jm991014
reviewed
Jan 19, 2025
| val tradeStatus: String = "", | ||
| val productPhotoUrls: List<String> = emptyList(), | ||
| val marketInfo: MarketInfoUiState = MarketInfoUiState(), | ||
| val marketReviews: List<MarketReviewUiState> = emptyList(), |
There was a problem hiding this comment.
p2: @immutable 붙여도 좋을 것 같아요~
jm991014
reviewed
Jan 19, 2025
Comment on lines
3
to
19
| enum class ProductCondition(val label: String) { | ||
| BRAND_NEW("미개봉"), | ||
| SLIGHTLY_USED("약간의 사용감"), | ||
| USED("사용감 있음"), | ||
| LIGHTLY_USED("약간 사용감 있음"); | ||
|
|
||
| companion object { | ||
| fun fromCondition(condition: String?): ProductCondition { | ||
| return when (condition) { | ||
| BRAND_NEW.label -> BRAND_NEW | ||
| SLIGHTLY_USED.label -> SLIGHTLY_USED | ||
| USED.label -> USED | ||
| LIGHTLY_USED.label -> LIGHTLY_USED | ||
| else -> BRAND_NEW | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
p1: 수정하고 추후 공통 type으로 이동시킵시다
jm991014
reviewed
Jan 19, 2025
| itemChatGraph( | ||
| modifier = Modifier.systemBarsPadding(), | ||
| onNavigateUp = navigator.navController::navigateUp, | ||
| ) | ||
| } | ||
| } |
jm991014
approved these changes
Jan 19, 2025
yeonjeen
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
KakaoTalk_20250117_234649909.mp4
KakaoTalk_20250117_234649866.mp4
To Reviewers 📢
상세페이지 만들어봤습니다!