Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat [#109] 지난 공연 제외하는 기능 추가 #110

Merged
merged 8 commits into from
Jan 20, 2025
Merged

feat [#109] 지난 공연 제외하는 기능 추가 #110

merged 8 commits into from
Jan 20, 2025

Conversation

ch1hyun
Copy link
Collaborator

@ch1hyun ch1hyun commented Jan 18, 2025

✨ Issue Number ✨

closes #109

✨ To-do ✨

  • 지난 공연 제외하는 기능 추가
  • 존재 여부 및 좋아요 여부 검증 로직 분리
  • 타임테이블에 추가한 끝나지 않은 페스티벌 조회하도록 변경

✨ Description ✨  

@ch1hyun ch1hyun added the ✨ Feature 기능 개발 label Jan 18, 2025
@ch1hyun ch1hyun self-assigned this Jan 18, 2025
Ivoryeee
Ivoryeee approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@Ivoryeee Ivoryeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기능 로직을 깔끔하게 작성해 주셔서 앞으로도 잘 사용하기에 좋을 것 같아요! 수고 많으셨습니다 👍🏻

src/main/java/org/sopt/confeti/api/user/facade/UserFavoriteFacade.java Show resolved Hide resolved
.../org/sopt/confeti/domain/timetablefestival/infra/repository/TimetableFestivalRepository.java Show resolved Hide resolved
@ch1hyun ch1hyun merged commit 4b4e224 into develop Jan 20, 2025
2 checks passed
@ch1hyun ch1hyun deleted the feat#109 branch January 20, 2025 07:06
@ch1hyun ch1hyun mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivoryeee Ivoryeee Ivoryeee approved these changes

Assignees

@ch1hyun ch1hyun

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 지난 공연 제외하는 기능 추가
2 participants
@ch1hyun @Ivoryeee