Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] 나의 모임 전체 조회 API response body 수정 #175

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

2hyunjinn
Copy link
Member

PULL REQUEST

#️⃣관련 이슈

🎋 작업중인 브랜치

💡 작업내용

  • 나의 모임 전체 조회 API response body 수정

🔑 주요 변경사항

  • 나의 모임 전체 조회 API response body 수정

🏞 스크린샷

image

closes #174

@2hyunjinn 2hyunjinn added the 🔨 fix fix error or bug label Jan 22, 2025
@2hyunjinn 2hyunjinn requested a review from khyojun January 22, 2025 16:30
@2hyunjinn 2hyunjinn self-assigned this Jan 22, 2025
Copy link

Test Results

15 files  15 suites   2s ⏱️
66 tests 66 ✅ 0 💤 0 ❌
70 runs  70 ✅ 0 💤 0 ❌

Results for commit 32d47f9.

Copy link
Member

@khyojun khyojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 확인만 해주세요! 나중에 네이밍 제대로 지어보죠!

@@ -92,7 +92,11 @@ public ResponseEntity<ApiResponse<List<MyGroupResponse>>> getMyGroups(
throw new GongBaekException(ResponseError.BAD_REQUEST);
}

return ResponseBuilder.ok(groupFacade.getMyGroups(userId, category, status));
FinalMyGroupResponse finalResponse = new FinalMyGroupResponse(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 final 언제까지 가는지 보고 마지막에 이름 수정할게요!

@khyojun khyojun merged commit 6d1998a into main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 fix fix error or bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 나의 모임 전체 조회 API response body 수정
2 participants