Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] 회원가입 진행 시 빠진 검증 기능 추가 #186

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

khyojun
Copy link
Member

@khyojun khyojun commented Jan 24, 2025

PULL REQUEST

#️⃣관련 이슈

🎋 작업중인 브랜치

💡 작업내용

  • 회원가입 진행 시 따로 검증한 과정이 없어 검증 기능 추가하였습니다.

🔑 주요 변경사항

  • timeTable 겹치는 정보 있는지 검증
  • timeTable 시간 유효하게 왔는지 검증
  • 닉네임 검증
  • 소개글 검증
  • 닉네임 중복 검증

🏞 스크린샷

스크린샷을 첨부해주세요.

timeTable 겹치는 정보 있는지 검증

image

timeTable 시간 유효하게 왔는지 검증

image

닉네임 검증

image

소개글 검증 (나머지 케이스 테스트 코드에서 검증 진행)

image

닉네임 중복 검증

image

closes #185

@khyojun khyojun added the 🔨 fix fix error or bug label Jan 24, 2025
@khyojun khyojun requested a review from 2hyunjinn January 24, 2025 13:14
@khyojun khyojun self-assigned this Jan 24, 2025
Copy link

github-actions bot commented Jan 24, 2025

Test Results

15 files  ±0  15 suites  ±0   2s ⏱️ ±0s
66 tests ±0  66 ✅ ±0  0 💤 ±0  0 ❌ ±0 
70 runs  ±0  70 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6869d09. ± Comparison against base commit 6d173cb.

♻️ This comment has been updated with latest results.

Copy link
Member

@2hyunjinn 2hyunjinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘쥐티엠!!!! ㅋㅋ 저 조건문을 왜 발견 못했을까.... && 가 아니라 || 이라니...

@khyojun khyojun merged commit 4657aa3 into main Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 fix fix error or bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hotfix] 회원가입시 검증 빠진 작업 추가
2 participants