Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #78

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix tests #78

merged 1 commit into from
May 14, 2024

Conversation

giggio
Copy link
Member

@giggio giggio commented May 12, 2024 •
edited
Loading

Testes estão falhando. Arrumei a estrutura para pelo menos os testes básicos passarem e coloquei os testes no build.
Coloquei o plugin de eslint para o Jest.
Arrumei também a estrutura de testes e2e, unificando a configuração.

@Luc-cpl
Copy link

Luc-cpl commented May 12, 2024

Também corrigido no #35

@Luc-cpl Luc-cpl mentioned this pull request May 13, 2024
Closed
@giggio
Copy link
Member Author

giggio commented May 14, 2024

Pessoal, tá dando conflito agora, preciso saber qual PR vocês preferem, se forem seguir com o outro eu fecho esse e não corrijo os erros de merge, ou eu corrijo.

@filipepacheco
Copy link
Contributor

filipepacheco commented May 14, 2024 •
edited
Loading

Pessoal, tá dando conflito agora, preciso saber qual PR vocês preferem, se forem seguir com o outro eu fecho esse e não corrijo os erros de merge, ou eu corrijo.

corrige o conflito please @giggio
ia ser mergeado e já subido pra master hoje mas com o conflito deixamos pra amanhã

@giggio
Copy link
Member Author

giggio commented May 14, 2024

Pessoal, tá dando conflito agora, preciso saber qual PR vocês preferem, se forem seguir com o outro eu fecho esse e não corrijo os erros de merge, ou eu corrijo.

corrige o conflito please @giggio ia ser mergeado e já subido pra master hoje mas com o conflito deixamos pra amanhã

@filipepacheco feito, e testes seguem passando.

@filipepacheco filipepacheco merged commit a88475b into SOS-RS:develop May 14, 2024
1 check passed
@giggio giggio deleted the gb/fixtests branch May 15, 2024 02:25
@giggio
Copy link
Member Author

giggio commented May 15, 2024

\o/

@Luc-cpl Luc-cpl mentioned this pull request May 15, 2024
Closed
filipepacheco pushed a commit to filipepacheco/sos-rs-backend that referenced this pull request May 15, 2024
@giggio @filipepacheco
Fix tests (SOS-RS#78)
06dd5b9
filipepacheco pushed a commit to filipepacheco/sos-rs-backend that referenced this pull request May 15, 2024
@giggio @filipepacheco
Fix tests (SOS-RS#78)
2e9dc33
HelioDantas pushed a commit to HelioDantas/backend that referenced this pull request May 16, 2024
@giggio @HelioDantas
Fix tests (SOS-RS#78)
9732790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovanifranz giovanifranz giovanifranz approved these changes

@codingwithmath codingwithmath codingwithmath approved these changes

@MatheusDubin MatheusDubin MatheusDubin approved these changes

@williandandrade williandandrade williandandrade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@giggio @Luc-cpl @filipepacheco @williandandrade @MatheusDubin @codingwithmath @giovanifranz