Conversation
JeonSuna
changed the title
duwlsssss
approved these changes
Apr 11, 2025
Contributor
duwlsssss
left a comment
duwlsssss
left a comment
There was a problem hiding this comment.
서버 연결이랑 회원가입도 구현 부탁해욥
너무 고생했어요 👏👏
| @@ -0,0 +1,23 @@ | |||
| VITE_TMDB_KEY=eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiI0MzYwYjI5NzdjY2M1MzFiYmFiNDA3YmY2ZjRiYWY4ZCIsIm5iZiI6MTc0MzU2ODUzMC4xOTgwMDAyLCJzdWIiOiI2N2VjYmU5MmUxNTdhZWYzZjIwMTJkOGQiLCJzY29wZXMiOlsiYXBpX3JlYWQiXSwidmVyc2lvbiI6MX0.Qi_B2BzRgaD3lVQgwQY7Xx3XwgmfcqhJ5Xtu0Ha7oCY | |||
Contributor
There was a problem hiding this comment.
.env .gitignore에 추가해야 할 것 같아요!!
| // console.log(isHovered); | ||
| return ( | ||
| <div | ||
| onClick={(): void | Promise<void> => navigate(`/movie/${item.id}`)} |
Contributor
There was a problem hiding this comment.
여기서 return type으로 Promise는 필요 없을 것 같습니당
| //data type (detail,movie type이 섞임 | ||
| } | ||
|
|
||
| export default function useCustomFetch<T>(url: string): ApiResponse<T> { |
Contributor
There was a problem hiding this comment.
혹시 파일 이름을 useCustomFetch가 아닌 useApiEffect로 한 이유가 있나요??
| import { Outlet } from "react-router-dom"; | ||
| import NavBar from "../components/Navbar"; | ||
|
|
||
| export default function Layout() { |
Contributor
There was a problem hiding this comment.
이 파일은 안에서 Layout 컴포넌트를 default export하니까 이름을 Layout.tsx 로 수정하는 게 좋을 것 같아요!
starvingorange
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ 작업 내용
#️⃣ 연관된 이슈
#20
📷 작업 결과
2025-04-10.163001.mp4
2025-04-10.163232.mp4
💡 함께 공유하고 싶은 부분
🤔 질문
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트