Conversation
duwlsssss
approved these changes
Apr 3, 2025
Comment on lines
+2
to
+5
| import { RootLayout } from "./layout/root-layout"; | ||
| import { HomePage } from "./page/HomePage"; | ||
| import { MovieListPage } from "./page/MovieListPage"; | ||
| import { MovieDetailPage } from "./page/MovieDetailPage"; |
Contributor
There was a problem hiding this comment.
혹시 default export를 안 쓴 이유가 있는지 궁금해용
Author
There was a problem hiding this comment.
아 이거 리팩토링하면서 default가 빠진것같아요...ㅎㅎ
Comment on lines
+7
to
+12
| const movieListTypes = ["popular", "upcoming", "top_rated", "now_playing"]; | ||
|
|
||
| const movieListRoutes = movieListTypes.map((type) => ({ | ||
| path: `movies/${type}`, | ||
| element: <MovieListPage />, | ||
| })); |
Contributor
There was a problem hiding this comment.
너무 깔끔한 방법이네요!
movieListTypes는 const 폴더 만들어서 넣어놔도 좋을 것 같아용
| const pathname = window.location.pathname; | ||
|
|
||
| return ( | ||
| <nav className="flex h-15 items-center px-5 gap-4"> |
Contributor
There was a problem hiding this comment.
nav도 상수화하고 map으로 순회하며 중복 코드를 줄일 수 있을 것 같아요!
|
우왕 로딩스피너 꿀팁 감사해용 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ 작업 내용
#️⃣ 연관된 이슈
#11
📷 작업 결과
2025-04-03.2.16.39-1.mov
2025-04-03.2.14.24-1.mov
💡 함께 공유하고 싶은 부분
https://cssloaders.github.io/
로딩 스피너는 여기서 마음에 드는거 쓰면 좋아용
🤔 질문
질문은 아니고... 디자인 어려워요,,
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
2025-04-03.2.14.24-1.mov