[week4/mission] 첫 커스텀 훅 만들어보기, 로그인 / 회원가입 기능 구현해보기 (feat. 유효성 검사)#24
Open
namgungseok12 wants to merge 3 commits intojay/mainfrom
Open
[week4/mission] 첫 커스텀 훅 만들어보기, 로그인 / 회원가입 기능 구현해보기 (feat. 유효성 검사)#24namgungseok12 wants to merge 3 commits intojay/mainfrom
namgungseok12 wants to merge 3 commits intojay/mainfrom
Conversation
duwlsssss
approved these changes
Apr 11, 2025
| @@ -0,0 +1 @@ | |||
| VITE_TMDB_KEY=eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiJlNjQzNjUzNTUyY2E5NjIxZGYxMDgwMjk3ODcwMTQ0MiIsIm5iZiI6MTc0MzY4NjE2Ny4zNjYwMDAyLCJzdWIiOiI2N2VlOGExNzU0ZjU5NWJiNTVhN2I3YWYiLCJzY29wZXMiOlsiYXBpX3JlYWQiXSwidmVyc2lvbiI6MX0.KEBQKM1JXCfZKAo7DIf9iLBUKJ3e4GAebLJNsPSaMVY No newline at end of file | |||
Contributor
There was a problem hiding this comment.
.env .gitignore에 추가해서 force push 필요할 듯...
Comment on lines
+13
to
+41
| // const [movie,setMovie] = useState<MovieDetailResponse>() | ||
| // const [isPending,setIsPending] = useState(false) // loading state | ||
| // const [isError,setIsError] = useState(false) // error state | ||
|
|
||
|
|
||
| // useEffect(() => { | ||
| // const fetchMovies = async () => { | ||
| // setIsPending(true) | ||
|
|
||
| // try{ | ||
| // const {data} = await axios.get<MovieDetailResponse>( | ||
| // ``, | ||
| // { | ||
| // headers: { | ||
| // Authorization: `Bearer ${import.meta.env.VITE_TMDB_KEY}`, | ||
| // } | ||
| // }, | ||
| // ); | ||
|
|
||
| // setMovie(data); | ||
| // }catch{ | ||
| // setIsError(true); | ||
| // }finally{ | ||
| // setIsPending(false); | ||
| // } | ||
| // }; | ||
|
|
||
| // fetchMovies(); | ||
| // }, [params.movieId]); |
duwlsssss
reviewed
Apr 11, 2025
|
|
||
| const MovieDetailPage =() => { | ||
|
|
||
| const params:Readonly<Params<string>> = useParams() |
Contributor
There was a problem hiding this comment.
useParams로 가져온 값은 어차피 직접 수정하지 않고, Params도 굳이 쓸 필요 없어 보여서
const { movieId } = useParams<{ movieId: string }>();
이렇게 간단히 타입 정의할 수 있어용
oortmealy
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ 작업 내용
#️⃣ 연관된 이슈
#20
📷 작업 결과
💡 함께 공유하고 싶은 부분
🤔 질문
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트