Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide links alumni #684

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Hide links alumni #684

merged 5 commits into from
Sep 25, 2024

Conversation

bradystroud
Copy link
Member

@bradystroud bradystroud commented Sep 25, 2024

Did a bit of maintenance.

The only change to the site behavior is hiding social links on Alumni pages.
See email Re: SSW CRM - Remove broken link - John Xu
#683

See this diff
https://github.com/SSWConsulting/SSW.People/pull/684/files#diff-fb6d9bddf82815a272c331263c9d030f6a68366c08bf2c7fed851744171d35c2R124-R138

image
Figure: ❌ Old - scrolling is annoying

image
Figure: ✅ new - nice, but a bit smaller

src/components/profile-description/profile-description.js Outdated Show resolved Hide resolved
src/components/profile-utils/profile-photo-utils.jsx Outdated Show resolved Hide resolved
src/components/social-links/social-links.js Outdated Show resolved Hide resolved
src/templates/person.js Outdated Show resolved Hide resolved
@bradystroud bradystroud merged commit 3abba53 into main Sep 25, 2024
2 checks passed
@bradystroud bradystroud deleted the hide-links-alumni branch September 25, 2024 05:26
This was referenced Sep 25, 2024
@bradystroud bradystroud linked an issue Sep 25, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Contribuitions - Can we avoid horizontal scrolling?
2 participants