Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/io/std renaming #703

Merged
merged 12 commits into from
Feb 28, 2025

Rename 'attach(...)' -> 'open(...)', 'attached()' -> 'is_open()', and…

a7812da
Select commit
Loading
Failed to load commit list.
Merged

Internal/io/std renaming #703

Rename 'attach(...)' -> 'open(...)', 'attached()' -> 'is_open()', and…
a7812da
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 28, 2025 in 0s

97.275% (-0.764%) compared to 1aa125e

View this Pull Request on Codecov

97.275% (-0.764%) compared to 1aa125e

Details

Codecov Report

Attention: Patch coverage is 97.84736% with 11 lines in your changes missing coverage. Please review.

Project coverage is 97.275%. Comparing base (1aa125e) to head (a7812da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/adiar/internal/data_structures/sorter.h 73.333% 8 Missing ⚠️
...nternal/data_structures/levelized_priority_queue.h 71.429% 2 Missing ⚠️
src/adiar/internal/io/node_ofstream.h 96.154% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #703       +/-   ##
=============================================
- Coverage   98.038%   97.275%   -0.764%     
=============================================
  Files           93        95        +2     
  Lines         7137      7265      +128     
=============================================
+ Hits          6997      7067       +70     
- Misses         140       198       +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.