Skip to content

Conversation

@buttonwillowsix
Copy link
Contributor

NOT READY FOR REVIEW

Summary

  • Scheduled unpublish for News and Events

Review By (Date)

  • No rush

Criticality

  • Not critical

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Publish an event or news item
  3. Schedule unpublish
  4. Check bac!

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? YES

Front End Validation

No front-end impact

Backend / Functional Validation

Code

  • [YES ] Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • [ NOPE] Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • [Nope ] Is there anything included in this PR that is not related to the problem it is trying to solve?
  • [ Yes] Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants