feat(packages/sui-react-router): avoid extra render during first load #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresz1
requested review from
sui-bot,
kikoruiz and
carlosvillu
as code owners
andresz1
force-pushed
the
feat/avoid-router-rerender
branch
from
abe3d62 to
78a6aef
Compare
andresz1
changed the title
jordevo
approved these changes
Nov 2, 2023
javiauso
approved these changes
Nov 2, 2023
AgonisticKatai
approved these changes
Nov 2, 2023
oriolpuig
approved these changes
Nov 2, 2023
nachoAdevinta
approved these changes
Nov 2, 2023
andresz1
commented
Nov 2, 2023
| @@ -66,15 +66,26 @@ const Router = ({ | |||
|
|
|||
| useEffect(() => { | |||
| let prevState = {} | |||
| let isSkipped = !!matchContext | |||
There was a problem hiding this comment.
If matchContext is provided that means that we can avoid the setState being execute since the router properties are going to be the same
kikoruiz
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR avoid an extra re-render in the
Routercomponent. Normally this causes the application to re-render twice during first loadRelated Issue
None
Example
None