feat(packages/sui-react-web-vitals): add visibilityState property #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucliweb
requested review from
sui-bot,
kikoruiz,
andresz1 and
carlosvillu
as code owners
jordevo
approved these changes
Nov 7, 2023
andresz1
approved these changes
Nov 7, 2023
jordevo
reviewed
Nov 7, 2023
| @@ -113,7 +113,8 @@ export default function WebVitalsReporter({ | |||
| path: hasPathOnRoute ? pathname : getNormalizedPathname(pathname), | |||
| target, | |||
| loadState: attribution.loadState, | |||
| ...(attribution.eventType && {eventType: attribution.eventType}) | |||
| ...(attribution.eventType && {eventType: attribution.eventType}), | |||
| visibilityState: document.visibilityState | |||
There was a problem hiding this comment.
I'm assuming document will be available because we're inside a useMount
There was a problem hiding this comment.
Yes, we have access to document inside a useMount
oriolpuig
approved these changes
Nov 7, 2023
kikoruiz
approved these changes
Nov 7, 2023
carlosvillu
approved these changes
Nov 7, 2023
|
I reckon it'd be great to add some documentation on the package's readme so that's easy to know the new stuff that's available. |
I agree; first, we want to test if this info will be useful. We are looking for quick wins to improve the INP metric. #1657 created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Example