feat(packages/sui-react-web-vitals): add sub inp metrics to cwv#1669
Merged
feat(packages/sui-react-web-vitals): add sub inp metrics to cwv#1669
Conversation
andresz1
requested review from
carlosvillu,
kikoruiz and
sui-bot
as code owners
jordevo
approved these changes
Nov 23, 2023
andresz1
commented
Nov 23, 2023
nucliweb
reviewed
Nov 23, 2023
| ...(routeid | ||
| ? [ | ||
| { | ||
| key: 'routeid', |
nucliweb
reviewed
Nov 23, 2023
Collaborator
|
👀 Remember to update the package.json to upgrade to a major version |
carlosvillu
approved these changes
Nov 27, 2023
carlosvillu
approved these changes
Nov 27, 2023
BREAKING CHANGES: pathname for allowed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Breaking changes:
pathnamesprop withallowed(an optional array of pathnames or route ids that you want to track). This will allow us to filter by route ids.This change will require a new major
Related Issue
Example