Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages/sui-bundler): add server dev config #1673

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

andresz1
Copy link
Member

Description

This PR adds an initial webpack configuration to enable Server-Side Rendering Fast Refresh support during development

Related Issue

Example

@jordevo
Copy link
Contributor

jordevo commented Nov 30, 2023

I wonder if this should go...?

mode: process.env.NODE_ENV === 'production' ? 'production' : 'development',

@andresz1
Copy link
Member Author

andresz1 commented Dec 1, 2023

I wonder if this should go...?

mode: process.env.NODE_ENV === 'production' ? 'production' : 'development',

This file is specific to work with Server-Side rendering in development mode. We can consider a merge in the future but let's keep it isolated while we perform some tests

@andresz1 andresz1 merged commit af30bdd into master Dec 1, 2023
1 check passed
@andresz1 andresz1 deleted the feat/ssr-fast-refresh branch December 1, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants