feat(packages/sui-bundler): add resources as static folder #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresz1
requested review from
sui-bot,
kikoruiz and
carlosvillu
as code owners
jordevo
approved these changes
Jan 24, 2024
carlosvillu
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add resources as static folder. The agreement of statics folders will be as follows:
/public: Automatically generated folder for the build and ignored in git./statics: Folder where the server itself will expose its content from the root. For example, it is useful for hosting sitemaps.xml, robots.txt, etc./resources: Folder that will be synchronized with the application's S3 bucket and exposed through a CDN. For example, it is useful for hosting images, JSONs, PDFs, etc.Important: Only place strictly necessary items in
/statics; the majority should go in/resourcesto be served by a CDN and not consume server resources.Related Issue
None
Example
None