Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with commit confirmed / commit_message on EOS #322

Merged

Conversation

indy-independence
Copy link
Member

commit_message not implemented on napalm EOS driver, causes error with commit_mode 0. don't wait for rollback on commit mode 0

…h commit_mode 0. don't wait for rollback on commit mode 0
@indy-independence indy-independence added the bug Something isn't working label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (fe3be7e) 65.56% compared to head (4dbb55c) 65.46%.
Report is 45 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #322      +/-   ##
===========================================
- Coverage    65.56%   65.46%   -0.11%     
===========================================
  Files           66       66              
  Lines         7283     7325      +42     
===========================================
+ Hits          4775     4795      +20     
- Misses        2508     2530      +22     
Files Coverage Δ
src/cnaas_nms/app_settings.py 96.66% <100.00%> (+0.03%) ⬆️
src/cnaas_nms/scheduler/scheduler.py 72.15% <100.00%> (-0.46%) ⬇️
src/cnaas_nms/version.py 100.00% <100.00%> (ø)
src/cnaas_nms/devicehandler/firmware.py 30.84% <0.00%> (ø)
src/cnaas_nms/db/settings_fields.py 94.07% <64.28%> (-1.53%) ⬇️
src/cnaas_nms/run.py 16.23% <0.00%> (-0.73%) ⬇️
src/cnaas_nms/devicehandler/sync_devices.py 73.08% <54.83%> (-0.95%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@indy-independence indy-independence merged commit f8cd5e4 into develop Nov 14, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant