Simplified uptime check #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickenordin
reviewed
Dec 6, 2024
There was a problem hiding this comment.
maybe we should have this class take $warning and $critical as parameters, making it possible to override thw defaults?
There was a problem hiding this comment.
Sounds like a good idea.
| @@ -1,15 +1,17 @@ | |||
| # Check uptime | |||
| define sunet::nagios::nrpe_check_uptime ( | |||
| ) { | |||
There was a problem hiding this comment.
String $warning = '30',
String $critical = '50'
| } | ||
| sunet::nagios::nrpe_command {'check_uptime': | ||
| command_line => '/usr/lib/nagios/plugins/check_uptime.pl -f' | ||
| command_line => '/usr/lib/nagios/plugins/check_uptime.py' |
There was a problem hiding this comment.
command_line => "/usr/lib/nagios/plugins/check_uptime.py -w ${warning} -c ${critical}"
There was a problem hiding this comment.
Maybe add:
String $uptimew = '30',
String $uptimec = '50',
to params
manifests/nagios.pp
Outdated
| @@ -90,7 +90,7 @@ | |||
| command_line => "/usr/lib/nagios/plugins/check_procs -k -w ${_procw} -c ${_procc}" | |||
| } | |||
| sunet::nagios::nrpe_command {'check_uptime': | |||
| command_line => '/usr/lib/nagios/plugins/check_uptime.pl -f' | |||
| command_line => '/usr/lib/nagios/plugins/check_uptime.py' | |||
There was a problem hiding this comment.
and here it would be:
command_line => "/usr/lib/nagios/plugins/check_uptime.py -w ${uptimew} -c ${uptimec}"
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mickenordin
requested changes
Dec 10, 2024
richir-sunet
force-pushed
the
richir_new_check_uptime
branch
from
72cb252 to
08f4a69
Compare
richir-sunet
force-pushed
the
richir_new_check_uptime
branch
from
08f4a69 to
9251614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simplified uptime check script, with slightly different output. Old one also had a bug and was very hard to read.