Merge pull request #160 from asmorodskyi/fix_azure_imagedeletion

Fix regression caused by upgrade of Azure API libs
SUSE · Aug 7, 2022 · 4710773 · 4710773
2 parents 5dd602b + e6143d5
commit 4710773
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ocw/lib/azure.py b/ocw/lib/azure.py
@@ -206,7 +206,7 @@ def cleanup_images_from_rg(self, keep_images):
                     if self.dry_run:
                         self.log_info("Deletion of image {} skipped due to dry run mode", item.name)
                     else:
-                        self.compute_mgmt_client().images.delete(self.__resource_group, item.name)
+                        self.compute_mgmt_client().images.begin_delete(self.__resource_group, item.name)
 
     def cleanup_disks_from_rg(self, keep_images):
         for item in self.list_disks_by_resource_group(self.__resource_group):

diff --git a/tests/test_azure.py b/tests/test_azure.py
@@ -110,7 +110,7 @@ def mock_compute_mgmt_client(self):
         def compute_mgmt_client():
             pass
         compute_mgmt_client.images = lambda: None
-        compute_mgmt_client.images.delete = lambda rg, name: deleted_images.append(name)
+        compute_mgmt_client.images.begin_delete = lambda rg, name: deleted_images.append(name)
         return compute_mgmt_client
 
     monkeypatch.setattr(Azure, 'resource_mgmt_client', mock_res_mgmt_client)