Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCE: Also cleanup forwarding rules #293

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

ricardobranco777
Copy link
Collaborator

GCE: Also cleanup forwarding rules

Related ticket: https://progress.opensuse.org/issues/134069

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (cecc978) 79.05% compared to head (febdea9) 79.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   79.05%   79.17%   +0.11%     
==========================================
  Files          21       21              
  Lines        1585     1594       +9     
==========================================
+ Hits         1253     1262       +9     
  Misses        332      332              
Files Changed Coverage Δ
ocw/lib/gce.py 92.95% <100.00%> (+0.47%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asmorodskyi asmorodskyi merged commit a0ac689 into SUSE:master Aug 10, 2023
10 checks passed
@ricardobranco777 ricardobranco777 deleted the fix_gce branch August 10, 2023 11:30
Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants