Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint warnings in ocw/lib/k8s.py #294

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

pdostal
Copy link
Collaborator

@pdostal pdostal commented Aug 10, 2023

Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should always check pylint locally, but I think we can improve our workflow by having pylint in CI not tolerate any errors. But for this we'd have to add explicit disable's in the code. WDYT?

@pdostal
Copy link
Collaborator Author

pdostal commented Aug 10, 2023

We should always check pylint locally, but I think we can improve our workflow by having pylint in CI not tolerate any errors. But for this we'd have to add explicit disable's in the code. WDYT?

That's rather question for @asmorodskyi .

I'd anyways continue in separate pull request.

@asmorodskyi
Copy link
Collaborator

LGTM.

We should always check pylint locally, but I think we can improve our workflow by having pylint in CI not tolerate any errors. But for this we'd have to add explicit disable's in the code. WDYT?

LGTM for decrease tolerance here , main thing that we not merge with failed pipeline , until we keep this I am fine :)

@asmorodskyi asmorodskyi merged commit 2480949 into SUSE:master Aug 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants