Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: Clean image versions in Failed provisioning state #377

Merged
merged 1 commit into from
May 29, 2024

Conversation

ricardobranco777
Copy link
Collaborator

Clean image versions in Failed provisioning state

Observation: A lot of Azure objects have this provisioning_state attribute that we can take advantage of in other scenarios.

Related ticket: https://progress.opensuse.org/issues/160397

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.21%. Comparing base (3079eab) to head (80fba44).
Report is 3 commits behind head on master.

Files Patch % Lines
ocw/lib/azure.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   78.17%   78.21%   +0.05%     
==========================================
  Files          22       22              
  Lines        1676     1675       -1     
==========================================
  Hits         1310     1310              
+ Misses        366      365       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asmorodskyi
Copy link
Collaborator

there is conflicts please rebase

@ricardobranco777
Copy link
Collaborator Author

there is conflicts please rebase

Conflicts? Where?

@asmorodskyi asmorodskyi merged commit fc4eed9 into SUSE:master May 29, 2024
8 of 9 checks passed
@ricardobranco777 ricardobranco777 deleted the rmfailed branch May 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants