Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pcw_ignore for cleanup_images in gce #394

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

pdostal
Copy link
Collaborator

@pdostal pdostal commented Jul 16, 2024

$ podman run  -v ./pcw.ini:/etc/pcw.ini -v ./creds/:/var/pcw -v ./code/:/pcw -t localhost/suse/qac/pcw-devel:latest "python3 manage.py cleanup"
2024-07-16 08:05:52,414 ocw.lib.cleanup INFO     [ccoe] Run cleanup for GCE
2024-07-16 08:05:52,415 ocw.lib.gce  INFO     [ccoe] Call cleanup_all
2024-07-16 08:05:52,415 ocw.lib.gce  DEBUG    [ccoe] Images cleanup
2024-07-16 08:05:52,853 ocw.lib.gce  DEBUG    [ccoe] 12 images found
2024-07-16 08:05:52,892 ocw.lib.gce  INFO     [ccoe] Deletion of image sl-micro-6-0-aarch64-1-0-0-gce-build2-20 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sl-micro-6-0-byos-aarch64-1-0-0-gce-build2-19 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sl-micro-6-0-byos-aarch64-1-0-0-gce-build2-20 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sl-micro-6-0-byos-x8664-1-0-0-gce-build2-19 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sl-micro-6-0-byos-x8664-1-0-0-gce-build2-20 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sl-micro-6-0-x8664-1-0-0-gce-build2-20 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sles12-sp5-gce-x8664-1-0-11-byos-build4-102 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sles12-sp5-gce-x8664-1-0-14-sap-byos-build4-115 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sles12-sp5-gce-x8664-1-0-14-sap-byos-build4-116 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sles15-sp6-aarch64-1-0-0-gce-build1-27 skipped due to dry run mode
2024-07-16 08:05:52,893 ocw.lib.gce  DEBUG    [ccoe] Ignoring sles15-sp6-byos-aarch64-1-0-0-gce-build1-27 due to 'pcw_ignore' label set to '1'
2024-07-16 08:05:52,893 ocw.lib.gce  INFO     [ccoe] Deletion of image sles15-sp6-x8664-1-0-0-gce-build1-27 skipped due to dry run mode

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (e48fe12) to head (b7162f5).
Report is 1 commits behind head on master.

Files Patch % Lines
ocw/lib/gce.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   78.46%   78.45%   -0.00%     
==========================================
  Files          22       22              
  Lines        1717     1721       +4     
==========================================
+ Hits         1347     1350       +3     
- Misses        370      371       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a more generic message like Anton said. Otherwise LGTM.

@asmorodskyi
Copy link
Collaborator

please re-base on latest master to ( hopefully ) fix the pipeline

@asmorodskyi asmorodskyi merged commit 52a69d3 into SUSE:master Jul 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants