-
Notifications
You must be signed in to change notification settings - Fork 17
Adds general label handling for GCP #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds general label handling for GCP #430
Conversation
2b19ef9
to
bc678a0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 79.60% 79.47% -0.13%
==========================================
Files 21 21
Lines 1632 1631 -1
==========================================
- Hits 1299 1296 -3
- Misses 333 335 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Summary
This PR adds general label handling for Google Cloud objects.
There is an added check in
_delete_resource
so it affects all objects that have labels. Because of this I have removed the logic fromdisks
andimages
as it's no longer needed.Progress
Run logs