Bind mount the configured certs location bsc#1219004 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtamalin
requested review from
rjschwei,
guangyee,
jesusbv,
smarlowucf and
yarunachalam
smarlowucf
approved these changes
Feb 1, 2024
jesusbv
reviewed
Feb 2, 2024
rjschwei
requested changes
Feb 2, 2024
rjschwei
approved these changes
Feb 2, 2024
|
I'm going to squash the commits into as single commit before merging; helps with keeping the changes log management simpler ;-) |
When the migration is running ensure that the correct certs directory is bind mounted from the /system-root into the ISO boot's runtime environment, by retrieving the configured server.certlocation setting from the /system-root/etc/regionserverclnt.cfg file. Default to the new cert location if a cert location cannot be determined. Log a message when no certs are present in the cert location, checking in the system being migrated, and after the bind mount of that path into the ISO runtime environment. Add unit tests for new get_regionsrv_certs_path() function and tweak some existing tests, that depend upon mocking calls to builtin.open(), so that they mock any calls to get_regionsrv_certs_path() so as to avoid triggering additional open() calls that would break those tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the migration is running ensure that the correct certs directory is bind mounted from the /system-root into the ISO boot's runtime environment, by retrieving the configured server.certlocation setting from the /system-root/etc/regionserverclnt.cfg file.
Add unit tests for new get_regionsrv_certs_path() function and tweak some existing tests, that depend upon mocking calls to builtin.open(), so that they mock any calls to get_regionsrv_certs_path() so as to avoid triggering additional open() calls that would break those tests.