Fixed reading of extra config file #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MigrationConfig() was read in only once in the mount service. However for the container use case there is mount service. Thus the config file information was missing. For a more robust availability of the config information this patch adds the reading to all services that consumes it. In addition the change also prevents writing an 'all' status from systemd to the log file. This information is not relevant as the log contains information about the service runs. The data also floods the log with a lot of useless information and makes debugging more complicated
2 tasks
rjschwei
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MigrationConfig() was read in only once in the mount service. However in a more flexible workflow that does not require a mount service, the config file information would be missing. Also in case of an error in the mount service the data of the extra config file is not transported into other services that drives the cleanup.
For a more robust availability of the config information this patch adds the reading to all services that consumes it. In addition the change also prevents writing an 'all' status from systemd to the log file. This information is not relevant as the log contains information about the service runs. The data also floods the log with a lot of useless information and makes debugging more complicated