Refactor pta #1552
Merged
Refactor pta #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
+ Coverage 62.67% 62.88% +0.21%
==========================================
Files 245 245
Lines 25707 25687 -20
Branches 4502 4491 -11
==========================================
+ Hits 16111 16153 +42
+ Misses 9596 9534 -62
|
yuleisui
reviewed
Sep 20, 2024
svf/lib/WPA/Andersen.cpp
Outdated
| * callsites is candidate indirect callsites need to be analyzed based on points-to results | ||
| * newEdges is the new indirect call edges discovered | ||
| */ | ||
| void AndersenBase::onTheFlyThreadCallGraphSolve(const CallSiteToFunPtrMap& callsites, |
There was a problem hiding this comment.
can we move this to PointerAnalysis?
yuleisui
reviewed
Sep 20, 2024
svf/include/Graphs/ThreadCallGraph.h
Outdated
| @@ -407,6 +416,8 @@ class ThreadCallGraph: public CallGraph | |||
| CallInstToForkEdgesMap callinstToThreadForkEdgesMap; ///< Map a call instruction to its corresponding fork edges | |||
| CallInstToJoinEdgesMap callinstToThreadJoinEdgesMap; ///< Map a call instruction to its corresponding join edges | |||
| CallInstToParForEdgesMap callinstToHareParForEdgesMap; ///< Map a call instruction to its corresponding hare_parallel_for edges | |||
|
|
|||
| CallEdgeMap indirectForkMap; ///< Indirect call map | |||
There was a problem hiding this comment.
Do we really need this? or we could use existing maps?
yuleisui
reviewed
Sep 20, 2024
svf/include/Graphs/ThreadCallGraph.h
Outdated
| @@ -250,6 +251,14 @@ class ThreadCallGraph: public CallGraph | |||
| } | |||
| //@} | |||
|
|
|||
| /// Get callees from an indirect callsite | |||
| ///@{ | |||
| inline CallEdgeMap& getIndForkMap() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move updateCallGraph etc. to AndersenBase