Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add funcvar #1598

Merged
merged 3 commits into from
Nov 30, 2024
Merged

add funcvar #1598

merged 3 commits into from
Nov 30, 2024

Conversation

jumormt
Copy link
Contributor

@jumormt jumormt commented Nov 22, 2024

No description provided.

@jumormt
Copy link
Contributor Author

jumormt commented Nov 22, 2024

--- log/redis-server.log 2024-11-23 22:24:42.786280885 +1100
+++ log/redis-server-xiao.log 2024-11-23 22:26:20.009204378 +1100
@@ -31,9 +31,9 @@
VarArrayObj 831
VarStructObj 1664
----------------Time and memory stats--------------------
-LLVMIRTime 4.304
-SVFIRTime 2.52
-SymbolTableTime 0.572
+LLVMIRTime 4.761
+SVFIRTime 2.712
+SymbolTableTime 0.642
#######################################################

PTACallGraph Stats (Andersen analysis)******
@@ -60,11 +60,11 @@
CollapseTime 0
CopyGepTime 0
LoadStoreTime 0
-MemoryUsageVmrss 4.16476e+06
+MemoryUsageVmrss 4.16454e+06
MemoryUsageVmsize 4.16453e+06
SCCDetectTime 0
SCCMergeTime 0
-TotalTime 129.268
+TotalTime 129.251
UpdateCGTime 0
----------------Numbers stats----------------------------
AddrProcessed 17887
@@ -115,32 +115,32 @@
Persistent Points-To Cache Statistics: Andersen's analysis bitvector
################ (program : redis-server.bc)###############
UniquePointsToSets 44837
-TotalUnions 673050
+TotalUnions 673062
PropertyUnions 222658
-UniqueUnions 19260
-LookupUnions 395148
-PreemptiveUnions 35984
+UniqueUnions 19262
+LookupUnions 395146
+PreemptiveUnions 35996
TotalComplements 3364152
PropertyComplements 2998574
UniqueComplements 16887
LookupComplements 331806
PreemptiveComplements 16885
-TotalIntersections 4182801
-PropertyIntersections 4145520
-UniqueIntersections 840
-LookupIntersections 2154
-PreemptiveIntersections 34287
+TotalIntersections 4182811
+PropertyIntersections 4145494
+UniqueIntersections 848
+LookupIntersections 2172
+PreemptiveIntersections 34297
#######################################################

Memory SSA Statistics******
################ (program : redis-server.bc)###############
----------------Time and memory stats--------------------
AverageRegSize 85.727
-GenMUCHITime 1.853
-GenRegionTime 462.748
-InsertPHITime 0.547
-SSARenameTime 0.09
-TotalMSSATime 465.248
+GenMUCHITime 1.966
+GenRegionTime 513.809
+InsertPHITime 0.585
+SSARenameTime 0.083
+TotalMSSATime 516.448
----------------Numbers stats----------------------------
BBHasMSSAPhi 10755
CSChiNode 111246
@@ -163,13 +163,13 @@
SVFG Statistics******
################ (program : redis-server.bc)###############
----------------Time and memory stats--------------------
-ATNodeTime 0.846
+ATNodeTime 0.928
AvgWeight 167.789
ConnDirEdgeTime 0
-ConnIndEdgeTime 4.43
+ConnIndEdgeTime 4.47
OptTime 0
TLNodeTime 0
-TotalTime 5.276
+TotalTime 5.398
----------------Numbers stats----------------------------
ActualIn 163193
ActualOut 111246
@@ -231,20 +231,20 @@
GepTime 0
IndirectPropaTime 0
LoadTime 0
-MemoryUsageVmrss 3.57894e+06
-MemoryUsageVmsize 3.61746e+06
+MemoryUsageVmrss 3.58674e+06
+MemoryUsageVmsize 3.6212e+06
PhiTime 0
-PrelabelingTime 0.148
+PrelabelingTime 0.139
ProcessTime 0
PropagationTime 0
SCCTime 0
-SolveTime 441.365
+SolveTime 456.631
StoreTime 0
Strong/WeakUpdTime 0
-TotalTime 654.298
+TotalTime 696.712
UpdateCGTime 0
VersionPropTime 0
-meldLabelingTime 209.556
+meldLabelingTime 236.534
----------------Numbers stats----------------------------
CopysNum 14138
DummyFieldPtrs 2305
@@ -262,13 +262,13 @@
Pointers 494739
ProcessedAParam 0
ProcessedAddr 107322
-ProcessedCopy 162850
+ProcessedCopy 164271
ProcessedFRet 0
-ProcessedGep 868341
-ProcessedLoad 874876
+ProcessedGep 879876
+ProcessedLoad 869135
ProcessedMSSANode 2293638
-ProcessedPhi 104659
-ProcessedStore 321638
+ProcessedPhi 106726
+ProcessedStore 322168
SolveIterations 6
StoresNum 24164
StrongUpdates 3378
@@ -283,12 +283,12 @@

Persistent Points-To Cache Statistics: flow-sensitive analysis bitvector
################ (program : redis-server.bc)###############
-UniquePointsToSets 29728
-TotalUnions 1144666386
-PropertyUnions 989064136
-UniqueUnions 38169
-LookupUnions 155512743
-PreemptiveUnions 51338
+UniquePointsToSets 29868
+TotalUnions 1140463970
+PropertyUnions 977053095
+UniqueUnions 38732
+LookupUnions 163320068
+PreemptiveUnions 52075
TotalComplements 0
PropertyComplements 0
UniqueComplements 0

@yuleisui
Copy link
Collaborator

Funcval=>FunVal

Funcvar=>FunVar

@yuleisui
Copy link
Collaborator

Time stats have also increased significantly

@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.09091% with 21 lines in your changes missing coverage. Please review.

Project coverage is 62.99%. Comparing base (dc8d089) to head (5a6c48d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
svf/lib/SVFIR/SVFVariables.cpp 61.11% 14 Missing ⚠️
svf/lib/Util/SVFUtil.cpp 0.00% 3 Missing ⚠️
svf/lib/Graphs/ThreadCallGraph.cpp 71.42% 2 Missing ⚠️
svf/lib/SABER/SaberSVFGBuilder.cpp 66.66% 1 Missing ⚠️
svf/lib/Util/ThreadAPI.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   62.94%   62.99%   +0.05%     
==========================================
  Files         246      246              
  Lines       27343    27412      +69     
  Branches     4521     4529       +8     
==========================================
+ Hits        17211    17269      +58     
- Misses      10132    10143      +11
Files with missing lines Coverage Δ
svf-llvm/include/SVF-LLVM/LLVMModule.h 94.73% <100.00%> (+0.14%) ⬆️
svf-llvm/lib/LLVMModule.cpp 84.24% <100.00%> (+0.16%) ⬆️
svf-llvm/lib/SVFIRBuilder.cpp 84.52% <100.00%> (+0.47%) ⬆️
svf-llvm/lib/SVFIRExtAPI.cpp 85.24% <100.00%> (ø)
svf/include/Graphs/GenericGraph.h 81.44% <100.00%> (+0.19%) ⬆️
svf/include/Graphs/ICFGNode.h 83.09% <ø> (ø)
svf/include/SVFIR/SVFIR.h 100.00% <100.00%> (ø)
svf/include/SVFIR/SVFVariables.h 68.37% <100.00%> (+3.37%) ⬆️
svf/include/Util/SVFUtil.h 86.00% <ø> (ø)
svf/include/Util/ThreadAPI.h 100.00% <ø> (ø)
... and 16 more

... and 3 files with indirect coverage changes

@jumormt
Copy link
Contributor Author

jumormt commented Nov 22, 2024

Time stats have also increased significantly

Ok, I'll check.

@jumormt
Copy link
Contributor Author

jumormt commented Nov 22, 2024

I haven't merged the latest SVF master. I just reran both versions and the time stat is normal now:
--- log/redis-server.log 2024-11-23 01:47:11.652411669 +1100
+++ log/redis-server-xiao.log 2024-11-23 01:47:52.907989433 +1100
@@ -31,9 +31,9 @@
VarArrayObj 831
VarStructObj 1664
----------------Time and memory stats--------------------
-LLVMIRTime 4.257
-SVFIRTime 2.476
-SymbolTableTime 0.554
+LLVMIRTime 4.316
+SVFIRTime 2.517
+SymbolTableTime 0.55
#######################################################

PTACallGraph Stats (Andersen analysis)******
@@ -60,11 +60,11 @@
CollapseTime 0
CopyGepTime 0
LoadStoreTime 0
-MemoryUsageVmrss 4.16477e+06
+MemoryUsageVmrss 4.16465e+06
MemoryUsageVmsize 4.16454e+06
SCCDetectTime 0
SCCMergeTime 0
-TotalTime 125.897
+TotalTime 128.428
UpdateCGTime 0
----------------Numbers stats----------------------------
AddrProcessed 17887
@@ -115,32 +115,32 @@
Persistent Points-To Cache Statistics: Andersen's analysis bitvector
################ (program : redis-server.bc)###############
UniquePointsToSets 44837
-TotalUnions 673050
+TotalUnions 673064
PropertyUnions 222658
-UniqueUnions 19263
-LookupUnions 395145
-PreemptiveUnions 35984
+UniqueUnions 19259
+LookupUnions 395149
+PreemptiveUnions 35998
TotalComplements 3364152
PropertyComplements 2998574
UniqueComplements 16887
LookupComplements 331806
PreemptiveComplements 16885
-TotalIntersections 4182798
-PropertyIntersections 4145543
-UniqueIntersections 834
-LookupIntersections 2137
-PreemptiveIntersections 34284
+TotalIntersections 4182816
+PropertyIntersections 4145478
+UniqueIntersections 852
+LookupIntersections 2184
+PreemptiveIntersections 34302
#######################################################

Memory SSA Statistics******
################ (program : redis-server.bc)###############
----------------Time and memory stats--------------------
AverageRegSize 85.727
-GenMUCHITime 1.877
-GenRegionTime 454.979
-InsertPHITime 0.555
+GenMUCHITime 1.932
+GenRegionTime 490.242
+InsertPHITime 0.582
SSARenameTime 0.086
-TotalMSSATime 457.501
+TotalMSSATime 492.852
----------------Numbers stats----------------------------
BBHasMSSAPhi 10755
CSChiNode 111246
@@ -163,13 +163,13 @@
SVFG Statistics******
################ (program : redis-server.bc)###############
----------------Time and memory stats--------------------
-ATNodeTime 0.856
+ATNodeTime 0.87
AvgWeight 167.789
ConnDirEdgeTime 0
-ConnIndEdgeTime 4.468
+ConnIndEdgeTime 4.475
OptTime 0
TLNodeTime 0
-TotalTime 5.324
+TotalTime 5.345
----------------Numbers stats----------------------------
ActualIn 163193
ActualOut 111246
@@ -231,20 +231,20 @@
GepTime 0
IndirectPropaTime 0
LoadTime 0
-MemoryUsageVmrss 3.58736e+06
-MemoryUsageVmsize 3.61802e+06
+MemoryUsageVmrss 3.57212e+06
+MemoryUsageVmsize 3.61089e+06
PhiTime 0
-PrelabelingTime 0.147
+PrelabelingTime 0.138
ProcessTime 0
PropagationTime 0
SCCTime 0
-SolveTime 445.018
+SolveTime 448.373
StoreTime 0
Strong/WeakUpdTime 0
-TotalTime 659.41
+TotalTime 660.91
UpdateCGTime 0
VersionPropTime 0
-meldLabelingTime 211.043
+meldLabelingTime 209.111
----------------Numbers stats----------------------------
CopysNum 14138
DummyFieldPtrs 2305
@@ -262,13 +262,13 @@
Pointers 494739
ProcessedAParam 0
ProcessedAddr 107322
-ProcessedCopy 165092
+ProcessedCopy 163188
ProcessedFRet 0
-ProcessedGep 874801
-ProcessedLoad 873234
+ProcessedGep 867312
+ProcessedLoad 855572
ProcessedMSSANode 2293638
-ProcessedPhi 105845
-ProcessedStore 321643
+ProcessedPhi 104237
+ProcessedStore 317338
SolveIterations 6
StoresNum 24164
StrongUpdates 3378
@@ -283,12 +283,12 @@

Persistent Points-To Cache Statistics: flow-sensitive analysis bitvector
################ (program : redis-server.bc)###############
-UniquePointsToSets 29652
-TotalUnions 1169393112
-PropertyUnions 1005513092
-UniqueUnions 37998
-LookupUnions 163790900
-PreemptiveUnions 51122
+UniquePointsToSets 29453
+TotalUnions 1122736818
+PropertyUnions 971251998
+UniqueUnions 36970
+LookupUnions 151397999
+PreemptiveUnions 49851
TotalComplements 0
PropertyComplements 0
UniqueComplements 0

jumormt
jumormt commented Nov 25, 2024
View reviewed changes
svf/include/SVFIR/SVFIR.h Outdated
/// Add a memory obj node
inline NodeID addObjNode(const SVFValue* val, NodeID i)
inline NodeID addObjNode(const SVFValue* val, const CallGraphNode* callGraphNode, NodeID i)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split into multiple functions

@yuleisui yuleisui merged commit 4708c4e into SVF-tools:master Nov 30, 2024
5 checks passed
@jumormt jumormt deleted the 11.22 branch December 2, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jumormt @yuleisui