fix a bug of int128 #1624
Merged
fix a bug of int128 #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleisui
reviewed
Jan 8, 2025
svf-llvm/lib/SVFIRBuilder.cpp
Outdated
| llvmModuleSet()->addToLLVMVal2SVFVarMap( | ||
| fpValue, pag->getGNode(iter->second)); | ||
| } | ||
| else if (auto intValue = SVFUtil::dyn_cast<ConstantInt>(llvmValue)) | ||
| { | ||
| pag->addConstantIntObjNode(iter->first, intValue->getSExtValue(), intValue->getZExtValue(), iter->second); | ||
| std::pair<s64_t, u64_t> intVal = LLVMUtil::getIntegerValue(intValue); | ||
| pag->addConstantIntObjNode(iter->first, intVal.first, intVal.second, iter->second); |
There was a problem hiding this comment.
could you merge the 2nd and 3rd arguments as a pair?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1624 +/- ##
=======================================
Coverage 62.84% 62.85%
=======================================
Files 247 247
Lines 27700 27720 +20
Branches 4545 4547 +2
=======================================
+ Hits 17409 17424 +15
- Misses 10291 10296 +5
|
This reverts commit 75be147.
yuleisui
reviewed
Jan 8, 2025
svf/include/SVFIR/SVFIR.h
Outdated
| @@ -585,10 +585,10 @@ class SVFIR : public IRGraph | |||
| return addNode(node, i); | |||
| } | |||
|
|
|||
| inline NodeID addConstantIntValNode(const SVFValue* curInst, s64_t sval, u64_t zval, const NodeID i, | |||
| inline NodeID addConstantIntValNode(const SVFValue* curInst, std::pair<s64_t, u64_t> intValue, const NodeID i, | |||
There was a problem hiding this comment.
std::pair<s64_t, u64_t>& intValue
yuleisui
reviewed
Jan 8, 2025
svf/include/SVFIR/SVFIR.h
Outdated
| @@ -656,13 +656,12 @@ class SVFIR : public IRGraph | |||
| } | |||
|
|
|||
|
|
|||
| inline NodeID addConstantIntObjNode(const SVFValue* curInst, s64_t sval, u64_t zval, const NodeID i) | |||
| { | |||
| inline NodeID addConstantIntObjNode(const SVFValue* curInst, std::pair<s64_t, u64_t> intValue, const NodeID i) { | |||
yuleisui
reviewed
Jan 8, 2025
svf-llvm/lib/SVFIRExtAPI.cpp
Outdated
| @@ -64,7 +64,7 @@ const Type* SVFIRBuilder::getBaseTypeAndFlattenedFields(const Value* V, std::vec | |||
| { | |||
| SymbolTableBuilder builder(pag->getSymbolInfo()); | |||
| builder.collectSym(offset); | |||
| pag->addConstantIntValNode(svfOffset, offset->getSExtValue(), offset->getZExtValue(), pag->getSymbolInfo()->getValSym(svfOffset), nullptr); | |||
| pag->addConstantIntValNode(svfOffset, std::make_pair(offset->getSExtValue(), offset->getZExtValue()), pag->getSymbolInfo()->getValSym(svfOffset), nullptr); | |||
There was a problem hiding this comment.
LLVMUtil::getIntegerValue(offset)
There was a problem hiding this comment.
std::make_pair(offset->getSExtValue(), offset->getZExtValue()) => LLVMUtil::getIntegerValue(offset)
jumormt
pushed a commit
to jumormt/SVF-xiao
that referenced
this pull request
Jan 9, 2025
* fix a bug of int128 * wrap integer value function * revise the std::make_pair * Revert "revise the std::make_pair" This reverts commit 75be147. * fix addConstantIntObjNode and addConstantIntValNode * remove getSExt ZExt in SVF-LLVM --------- Co-authored-by: bjjwwang <bjjwwang@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.