Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 종료된 선물방 API 구현 #60

Merged
merged 6 commits into from
Jan 13, 2024
Merged

[feat] 종료된 선물방 API 구현 #60

merged 6 commits into from
Jan 13, 2024

Conversation

hysong4u
Copy link
Member

Related Issue 🍫

Summary 🍪

  • 종료된 선물방 API 구현
스크린샷 2024-01-13 오후 2 55 30

Before i request PR review 🍰

  • 선물방 선물 전달일(DeliveryDate)이 현재 시간보다 이전인 선물방에 대한 선물방 Id, 이미지, 이름, 참여자 수 조회
  • DeliveryDate가 최신순 부터 정렬(종료된 게 최근인 거 부터 정렬했습니당)

@hysong4u hysong4u added the FEAT 새로운 기능을 추가 label Jan 13, 2024
@hysong4u hysong4u self-assigned this Jan 13, 2024
ziiyouth
ziiyouth approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@ziiyouth ziiyouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

종료된 게 최근 정렬 좋네요!! 고생하셨습니당 👍

@hysong4u hysong4u merged commit cb2a6fa into develop Jan 13, 2024
1 check passed
@hysong4u hysong4u deleted the feature/#57-member branch February 5, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziiyouth ziiyouth ziiyouth approved these changes

Assignees

@hysong4u hysong4u

Labels
FEAT 새로운 기능을 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat]종료된 선물방 API 구현
2 participants
@hysong4u @ziiyouth