Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] 내 선물 조회하기 API 엔드포인트 변경 및 종료된 선물방 response 추가 #72

Merged
merged 2 commits into from
Jan 15, 2024
Merged

[fix] 내 선물 조회하기 API 엔드포인트 변경 및 종료된 선물방 response 추가 #72

merged 2 commits into from
Jan 15, 2024

Conversation

hysong4u
Copy link
Member

Related Issue 🍫

Summary 🍪

  • 내 선물 조회하기 API 엔드 포인트 변경
  • 종료된 선물방 response에 개설자 여부 추가

Before i request PR review 🍰

  • GET방식으로 ResponseBody사용이 어렵다고 전달받아서 @ResponseBody->@PathVariable로 변경했습니다
    (기존 엔드포인트와 겹치는 문제로 /my에서 /my-gift로 변경하긴 했는데,,, 다른 좋은 엔드포인트 추천 받습니다,,,,)
  • 종료된 선물방에 개설자 태그 추가됨에 따라 response에도 개설자 여부 추가했습니다.

@hysong4u hysong4u added the FEAT 새로운 기능을 추가 label Jan 15, 2024
@hysong4u hysong4u self-assigned this Jan 15, 2024
@hysong4u hysong4u merged commit 21009db into develop Jan 15, 2024
1 check passed
ziiyouth
ziiyouth reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@ziiyouth ziiyouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘해따!! 폰으로 봐서 못본 걸 수도 있는데 URL 겹치는 API 다른 건 delete라서 메소드가 다르면 이친구는 get의 /my로 가두 될듯??! 고마워용용

@hysong4u
Copy link
Member Author

아 맞넹 그럼 그대로 갈게용~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziiyouth ziiyouth ziiyouth left review comments

Assignees

@hysong4u hysong4u

Labels
FEAT 새로운 기능을 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 내 선물 조회하기 API 엔드포인트 변경 및 종료된 선물방 response 추가
2 participants
@hysong4u @ziiyouth