FIX: Handle updating options without changing other variables #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue in MSIS2 where some steps are cached in the Fortran code if the input values (lat, lon, ...) are unchanged between subsequent runs. This causes issues if one wants to compare what the differences are between the options switches. (MSIS00 didn't have this same cache) Additionally, add a check to the Python side to only call the init() function when options have changed, not every time we enter the run() call.
greglucas
force-pushed
the
fix-options
branch
from
2ceccac
to
b197870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue in MSIS2 where some steps are cached in the Fortran code if the input values (lat, lon, ...) are unchanged between subsequent runs. This causes issues if one wants to compare what the differences are between the options switches. (MSIS00 didn't have this same cache)
Additionally, add a check to the Python side to only call the init() function when options have changed, not every time we enter the run() call.
closes #59