Create LimelightMath.java #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't know the exact number for some variables or the exact format of the Limelight code, but I got the math for most (if not all) of the calculations to determine distances and their rate of change. I parsed whatever I didn't know or if the value would be imported from another class.
DanWaxman
requested changes
Feb 2, 2018
There was a problem hiding this comment.
The math itself looks good. However, a few things to change before merging:
- There's a lack of documentation for parameters and returns. Documentation is key to the usage of a lot of these methods.
- This class isn't in the package with the rest of the robot code.
- It utilizes an entrypoint and GUI components, neither of which are available on the robot (okay entrypoint maybe, but still not good practice).
After these changes are made, it looks good and will be good to push. Good job!
I removed all of the parsing at the beginning of the code to prevent dialog boxes from popping up. I didn't put in any computations/values for these variables since x and v would be imported from another source and y hasn't been determined yet. I also put in documentation stating what each variable means and what each method is calculating .
|
I updated the code: |
mehabu
approved these changes
Jan 25, 2019
mehabu
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't know the exact number for some variables or the exact format of the Limelight code, but I got the math for most (if not all) of the calculations to determine distances and their rate of change. I parsed whatever I didn't know or if the value would be imported from another class.