don't merge: code review #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sumeetrana
commented
Feb 14, 2023
| },[allProd.length, dispatch]) | ||
|
|
||
| const toggleshow = (id) => { | ||
| let dta = products.filter((el) => { |
There was a problem hiding this comment.
what does this dta variable determines? please give meaningful name to the variable. don't worry about the length of the variable name.
MAKE EACH STATE, VARIABLE AND FUNCTION NAME AS DESCRIPTIVE AS POSSIBLE
| position:'top-right' | ||
| }) | ||
| } | ||
| const [dataa, setDataa] = useState({}) |
There was a problem hiding this comment.
dataa? what does this state determine? it is not readable at all. Please change this state name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DON'T MERGE THIS BRANCH. Only to review comments on code