fix: escape single quotes in strings in generated Python code #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 119 119
Lines 12955 12955
Branches 4240 4240
=======================================
Hits 12920 12920
Misses 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lars-reimann
deleted the
1310-invalid-python-code-generated-for-strings-containing-a-single-quote
branch
lars-reimann
pushed a commit
that referenced
this pull request
Mar 8, 2025
## [0.24.0](v0.23.0...v0.24.0) (2025-03-08) ### Features * global attributes ([#1346](#1346)) ([fda30ab](fda30ab)) * new syntax for template strings ([#1311](#1311)) ([88295bc](88295bc)) * optional parameters must be passed by name ([#1307](#1307)) ([674cda8](674cda8)), closes [#1163](#1163) * type aliases ([#1334](#1334)) ([3d42bb0](3d42bb0)), closes [#1308](#1308) * update stubs for library version 0.30.0 ([#1345](#1345)) ([42178d1](42178d1)) ### Bug Fixes * allow callable types and union types in type aliases ([#1342](#1342)) ([b9374b5](b9374b5)) * do not suggest references to type alias ([#1343](#1343)) ([c5ef21d](c5ef21d)) * escape single quotes in strings in generated Python code ([#1312](#1312)) ([938f082](938f082)), closes [#1310](#1310) * handling of aliases of nullable types ([#1344](#1344)) ([99e1006](99e1006))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1310
Summary of Changes
Single quotes in strings are now escaped in the generated Python code.