Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: snapshot tests #495

Merged
merged 10 commits into from
Nov 22, 2023
Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 16, 2023

Closes #482
Closes #483

Summary of Changes

  • Use sypury snapshot tests for images. Run pytest --snapshot-update to update snapshots after changes.
  • Fix random test failures due to TCL when running tests in a terminal

@lars-reimann lars-reimann requested a review from a team as a code owner November 16, 2023 18:04
@lars-reimann lars-reimann linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Nov 16, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 9 0 0 0.63s
✅ PYTHON mypy 9 0 1.41s
✅ PYTHON ruff 9 0 0 0.08s
✅ REPOSITORY git_diff yes no 0.07s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann
Copy link
Member Author

@Gerhardsa0 please check whether you can now run the tests without random errors.
@Safe-DS/library I would appreciate it if one of you could review this.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6443beb) 100.00% compared to head (82de801) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #495   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2699      2699           
=========================================
  Hits          2699      2699           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit 6deddbe into main Nov 22, 2023
7 checks passed
@lars-reimann lars-reimann deleted the 483-dedicated-library-for-snapshot-testing branch November 22, 2023 13:10
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dedicated library for snapshot testing Buggy Tests
2 participants