Create role for snoflake access to synapsedev data with fake extID to get roleArn #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaro0508
approved these changes
Nov 22, 2023
zaro0508
reviewed
Nov 22, 2023
| url: https://{{stack_group_config.admincentral_cf_bucket}}.s3.amazonaws.com/aws-infra/v0.7.8/IAM/snowflake-bucket-access.yaml | ||
| stack_name: snowflake-access.yaml | ||
| parameters: | ||
| BucketArn: arn:aws:s3:::dev.datawarehouse.sagebase.org |
There was a problem hiding this comment.
this makes me wonder why the role for this bucket isn't created in the same template that created the bucket?
There was a problem hiding this comment.
Interesting thought, the goal was for org-infra to adopt resources already deployed into the with a shared template (with the benefit that the template can be used for to give Snowflake access to any bucket/prefix in the org)
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will create a new role for the snowflake access to Synapse dw bucket.
First called with fake externalID to get the role ARN.
Depends on Sage-Bionetworks/aws-infra#398