Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IT-3313] Setup infra for open data aws account #1032

Merged
merged 6 commits into from
Dec 6, 2023
Merged

[IT-3313] Setup infra for open data aws account #1032

merged 6 commits into from
Dec 6, 2023

Conversation

zaro0508
Copy link
Contributor

@zaro0508 zaro0508 commented Nov 21, 2023 •
edited
Loading

Bootstrap and setup basic infrastructure for the opendata AWS account. These are the base resources that we put on every account to allow us to easily manage the account using infrastructure as code.

depends on Sage-Bionetworks/aws-infra#401

@zaro0508
[IT-3313] Setup infra for ukbiobank open data
49c0a5a 
Bootstrap and setup basic infrastructure for the ukbiobank opendata AWS account.
These are the base resources that we put on every account to allow
us to easily manage the account using infrastructure as code.
@zaro0508 zaro0508 requested a review from a team as a code owner November 21, 2023 21:47
@brucehoff
Copy link
Contributor

ukbiobank opendata AWS account.
Please note that while this account is for use with the Amazon Open Data program, it is not specifically for the ukbiobank data set. ukbiobank is just one of the data sets to be hosted in this account.

@zaro0508
Copy link
Contributor Author

Please note that while this account is for use with the Amazon Open Data program, it is not specifically for the ukbiobank data set. ukbiobank is just one of the data sets to be hosted in this account.

Do you have a specific suggestion @brucehoff ? @xschildw created the account.

@xschildw
Copy link
Contributor

My understanding from the document in the issue was that we needed one account per dataset.

@brucehoff
Copy link
Contributor

Please note that while this account is for use with the Amazon Open Data program, it is not specifically for the ukbiobank data set. ukbiobank is just one of the data sets to be hosted in this account.

Do you have a specific suggestion @brucehoff ? @xschildw created the account.

Yes, you will be seeing specific suggestions in the PR regarding naming things. Aside from naming I don't think any changes need to be made. And sorry for not making this clear at the outset.

@brucehoff
Copy link
Contributor

My understanding from the document in the issue was that we needed one account per dataset.

@xschildw You read the document correctly however I believe we have a different arrangement with Open Data. I asked the question in Slack to double check with others working on this project.

brucehoff
brucehoff requested changes Nov 21, 2023
View reviewed changes
.github/workflows/main.yaml Outdated Show resolved Hide resolved
.github/workflows/main.yaml Outdated Show resolved Hide resolved
sceptre/ukbiobank-opendata/README.md Outdated Show resolved Hide resolved
sceptre/ukbiobank-opendata/README.md Outdated Show resolved Hide resolved
sceptre/ukbiobank-opendata/config/prod/jumpcloud-idp.yaml Outdated Show resolved Hide resolved
sceptre/ukbiobank-opendata/idp/jumpcloud/ukbiobank-opendata-admins.xml Outdated Show resolved Hide resolved
sceptre/ukbiobank-opendata/idp/jumpcloud/ukbiobank-opendata-auditors.xml Outdated Show resolved Hide resolved
sceptre/ukbiobank-opendata/idp/jumpcloud/ukbiobank-opendata-viewers.xml Outdated Show resolved Hide resolved
sceptre/ukbiobank-opendata/templates/jumpcloud-idp.yaml Outdated Show resolved Hide resolved
@zaro0508 zaro0508 requested review from brucehoff, xschildw and a team November 22, 2023 17:42
brucehoff
brucehoff approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@brucehoff brucehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

xschildw
xschildw approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@xschildw xschildw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpulls dpulls
Copy link

dpulls bot commented Dec 4, 2023

🎉 All dependencies have been resolved !

@zaro0508 zaro0508 changed the title [IT-3313] Setup infra for ukbiobank open data [IT-3313] Setup infra for open data aws account Dec 5, 2023
@zaro0508 zaro0508 merged commit 5416b27 into Sage-Bionetworks-IT:master Dec 6, 2023
25 checks passed
@zaro0508 zaro0508 mentioned this pull request Dec 6, 2023
Merged
zaro0508 added a commit that referenced this pull request Dec 7, 2023
@zaro0508
[IT-3313] single.cell.human.blood.atlas.opendata bucket (#1054)
78cbeb1 
The `single.cell.human.blood.atlas.opendata.sagebase.org` bucket
was manually deployed to the AWS opendata account previously. 
This will put it under Sceptre/cloudformation IaC control.

depends on #1032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xschildw xschildw xschildw approved these changes

@brucehoff brucehoff brucehoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaro0508 @brucehoff @xschildw